Contributor Guide
Welcome to Casdoor! This document serves as a guideline on how to contribute to Casdoor.
If you find any incorrect or missing information, please leave your comments or suggestions.
Get Involved
There are many ways to contribute to Casdoor. Here are some ideas to get started:
- Use Casdoor and report issues. When using Casdoor, report any issues - whether they're bugs or proposals - on GitHub Discussions or on Discord before filing an issue on GitHub.
Please use English to describe the details of your problem when reporting an issue.
Help with documentation. Starting your contribution work with docs is a good choice.
Help solve issues. We have a table that contains easy tasks suitable for beginners under Casdoor Easy Tasks, with different levels of challenges labeled with different tags.
Contributing
If you are ready to create a PR, here is the workflow for contributors:
Fork to your own repository.
Clone your fork to a local repository.
Create a new branch and work on it.
Keep your branch in sync.
Commit your changes. Make sure your commit message is concise.
Push your commits to your forked repository.
Create a pull request from your branch to our master branch.
Pull Requests
Before You Get Started
Casdoor uses GitHub as its development platform, and pull requests are the primary source of contributions.
Here are some things you need to know before opening a pull request:
You need to sign the CLA when you first create a pull request.
Explain why you are submitting the pull request and what it will do to the repo.
Only one commit is allowed. If the PR does more than one thing, please split it.
If there are any newly added files, please include the Casdoor license at the top of the new file(s).
// Copyright 2022 The Casdoor Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
Semantic PRs
Your pull requests should follow the Conventional Commits spec. The basic requirement is that only the PR title or at least one commit message. For example, three commonly used PR titles are given below:
PR titles must be in lowercase.
fix: a commit of the type
fix
patches a bug in your codebase.fix: prevent racing of requests
feat: a commit of the type
feat
introduces a new feature to the codebase.feat: allow provided config object to extend other configs
docs: a commit of the type
docs
adds or improves documentation.docs: correct spelling of CHANGELOG
For more details, please refer to the Conventional Commits page.
Linking PRs with Issues
You can link a pull request to an issue to show a fix is in progress and to automatically close the issue when the pull request is merged.
Linking a Pull Request to an Issue Using a Keyword
You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.
- close
- fix
- resolve
An issue in the same repository, for instance:
Fix: #902
For more details, please refer to Linking a Pull Request to an Issue.
Modifying PRs
Your PR may need revision. Please modify the same PR when the code needs changes; don't close the PR and open a new one. Here is an example:
Modify the code on your local.
Modify your commit.
git commit --amend
- Push to your remote repository.
git push --force
Then, you will have successfully modified the PR!
Code Related
Some Principles:
- Readability: important code should be well-documented. Code style should comply with the existing one.
Naming Convention
For instance, signupUrl
for variable names, Signup URL
for UI.
How to Update i18n Data?
Please note that we use Crowdin as a translating platform and i18next as a translating tool. When you add strings using i18next in the web/
directory, you can run the i18n/generate_test.go
to auto-generate web/src/locales/**/data.json
.
Run i18n/generate_test.go
:
cd i18n && go test
All languages are filled in English by default. After your PR has been merged, you are encouraged to help translate the newly added
strings in web/src/locales/zh/data.json
by Crowdin.
If you are not familiar with a language, please do not translate it; keep the file as it is.
License
By contributing to Casdoor, you agree that your contributions will be licensed under the Apache License.